Sounds right. If it speaks PPPoE then there's nothing more to do. Nothing to configure in the modem. ISP-specific login runes go into the router.
If you have an extremely long line, then it's worth considering applying Burakkucat's tip in the modem config: set the modem to ADSL2-only mode, as opposed to "auto" or ADSL2+. (Assuming you're on ADSL2 or ADSL2+, that is. If you are on ADSL1, then it might be worth setting the modem to ADSL1, rather than "auto".) Should really measure performance and compare.