Has anyone ever used VRRP ?
I've only ever used HSRP originally because it predated VRRP and latterly because of the specific enhancements in the Nexus switches. Also, I suppose inertia and lack of any perceived reason to do otherwise.
However I think the principle is the same, and I can't see how it could work without doing something on the PPPoE side as well. VRRP virtualises a LAN IP address only, not the whole router/firewall. Behind that LAN address the two devices will each be autonomous and working independently so if configured for PPPoE they'll both be trying to talk to the modems. You'd need something to synchronise it so that the device that's VRRP active on the LAN is the only one active on PPPoE.
Could that be done in the Firebrick with events and a triggered script? PPPoE stays shutdown, but a script triggered by VRRP becoming active enables it?