Kitz ADSL Broadband Information
adsl spacer  
Support this site
Home Broadband ISPs Tech Routers Wiki Forum
 
     
   Compare ISP   Rate your ISP
   Glossary   Glossary
 
Please login or register.

Login with username, password and session length
Advanced search  

News:

Pages: [1] 2 3

Author Topic: DSLstats pre-release version 6.3.5  (Read 7661 times)

roseway

  • Administrator
  • Senior Kitizen
  • *
  • Posts: 43432
  • Penguins CAN fly
    • DSLstats
DSLstats pre-release version 6.3.5
« on: March 31, 2018, 03:00:12 PM »

This version fixes all the reported issues on v6.3.4, and in addition it completes the FTP upload feature. All the files saved in the data store (or a selection of them) can be uploaded to an FTP server of the user's choice. Full list of changes:
  • fixed transitional webserver code which sometimes omitted the path delimiter when upgrading from a previous version
  • fixed duplicate event log messages about location of webserver files
  • FTP test upload files are now named "FTPtest1" and "FTPtest2" and are not deleted after upload
  • fixed the extra " in the error message "File .... failed to upload"
  • fixed the error in graph time per page when closing and restarting DSLstats
  • the names of the files in the data store now have the format "name-hours-minutes.zip"
  • the default Snapshots folder is now <config files location>/Snapshots
  • manual editing of snapshots, webserver and data store locations is now disallowed
  • regular FTP upload of all stats is now enabled using daily folders on the server
  • some small cosmetic changes
The FTP uploads are stored in daily folders on the server. DSLstats creates these daily folders as required, but the designated upload directory must exist before starting. The main stats are uploaded after each sample, as a single file for the day which grows after each sample. The optional per-tone zip files are uploaded once per hour.

I want this to be a release candidate for the next full release, so I would appreciate it if you could test it and report your findings.

Downloads available from http://dslstats.me.uk/downloads.html
Logged
  Eric

broadstairs

  • Kitizen
  • ****
  • Posts: 3697
Re: DSLstats pre-release version 6.3.5
« Reply #1 on: March 31, 2018, 04:25:08 PM »

Windows version running now. So far all OK. I have tested FTP and the test works. All directories are as expected. The FTP upload is working OK for Stats but windows complains it does not know what to open the file with as it has no extension, would be good to add one, also the data in the file is OK but alignment is off - there are two lines of data on the first line and all subsequent lines after first have an additional space in column 1 which might be problematic in parsing in future by program.

Also is there somewhere a document which shows what each value is in the Stats file?

Stuart
Logged
ISP:Vodafone Router:Vodafone Wi-Fi hub FTTP

tiffy

  • Kitizen
  • ****
  • Posts: 1319
Re: DSLstats pre-release version 6.3.5
« Reply #2 on: March 31, 2018, 04:38:21 PM »

Eric, many thanks for the latest program revision.
Just a few initial observations while testing on a RPi 3B+ test bed before updating to my "working" RPi's:

The snapshots new default folder as stated /home/pi/.dslstats/Snapshots is not created, in the configuration / snapshots window the path (not now changable) is /home/pi/.dslstats, on forcing a few test snapshots they are indeed stored in /home/pi/.dslstats folder.
Have tried manually creating a "Snapshots" folder in file manager but snapshots are still written to /home/pi/.dslstats..

Note that there are now 2 folders in /home/pi/.dslstats, "webserver" and "Webserver", obviously the "Webserver" folder has been created by this program revision and the "webserver" folder by a previous program revision.
Can the "webserver" folder and it's contents now be deleated ?
Presumably the kitz webserver files would now have to be copied to the "Webserver" folder ?

On a more positive note, the graph time per page, hours anomaly after program re-starting which I reported is definately sorted, many thanks for that.
« Last Edit: March 31, 2018, 04:41:19 PM by tiffy »
Logged
BT FTTP 150/30, BT Smart Hub 2

burakkucat

  • Respected
  • Senior Kitizen
  • *
  • Posts: 38300
  • Over the Rainbow Bridge
    • The ELRepo Project
Re: DSLstats pre-release version 6.3.5
« Reply #3 on: March 31, 2018, 06:44:52 PM »

Version 6.3.5 has been downloaded and examined. I see that the CHANGELOG and mime.types files both have the execution bit unnecessarily set.

Actual testing is about to be started.  :)
Logged
:cat:  100% Linux and, previously, Unix. Co-founder of the ELRepo Project.

Please consider making a donation to support the running of this site.

roseway

  • Administrator
  • Senior Kitizen
  • *
  • Posts: 43432
  • Penguins CAN fly
    • DSLstats
Re: DSLstats pre-release version 6.3.5
« Reply #4 on: March 31, 2018, 06:49:55 PM »

@Stuart: I've sent you a PM with an email address to send me a copy of your stats file. The reason is that I don't see the anomalies which you mention.

You can download a spreadsheet describing the format of the stats file at:
http://dslstats.me.uk/files/UploadStats.ods

Regarding the name of the stats file, I'd forgotten about Windows' funny habits. :) I'll change the name to 'stats.log' if that's OK with everyone.
« Last Edit: March 31, 2018, 07:21:29 PM by roseway »
Logged
  Eric

roseway

  • Administrator
  • Senior Kitizen
  • *
  • Posts: 43432
  • Penguins CAN fly
    • DSLstats
Re: DSLstats pre-release version 6.3.5
« Reply #5 on: March 31, 2018, 06:54:07 PM »

@b*cat: I don't know how that happened, but noted.
Logged
  Eric

roseway

  • Administrator
  • Senior Kitizen
  • *
  • Posts: 43432
  • Penguins CAN fly
    • DSLstats
Re: DSLstats pre-release version 6.3.5
« Reply #6 on: March 31, 2018, 07:01:48 PM »

@tiffy: The change in the snapshots folder is only the default, i.e. the value which is assigned to a new installation of DSLstats. If you already have an ini file from previous use, then your stored value will continue to be used.

The old 'webserver' folder can be deleted with all its contents. But anything you've manually added to it, such as the Kitz script, should be copied to the new folder first.

Thanks for confirming that the time per page saving and reloading works correctly.
Logged
  Eric

ktz392837

  • Reg Member
  • ***
  • Posts: 559
Re: DSLstats pre-release version 6.3.5
« Reply #7 on: March 31, 2018, 08:17:22 PM »

there are two lines of data on the first line and all subsequent lines after first have an additional space in column 1 which might be problematic in parsing in future by program.
Just to confirm I have the same issue with my RPI version at least with 6.3.4 not tried with .5 yet.  I noticed the extra spaces at the beginning of each line when first added but not noticed the two "lines" on the first line that is definitely the more troublesome one.

Edit: I guess if space is being used to indicate a value the extra spaces at the beginning of he lines are troublesome also.
« Last Edit: March 31, 2018, 08:19:30 PM by ktz392837 »
Logged

tiffy

  • Kitizen
  • ****
  • Posts: 1319
Re: DSLstats pre-release version 6.3.5
« Reply #8 on: March 31, 2018, 08:56:55 PM »

@tiffy: The change in the snapshots folder is only the default, i.e. the value which is assigned to a new installation of DSLstats. If you already have an ini file from previous use, then your stored value will continue to be used.

Eric, thanks for the response.

I most likely have not expressed myself very well, what I am trying to say:
In Configuration / Snapshots / Snapshots Directory: the default path stated is now /home/pi/.dslstats/ I would have expected this to be /home/pi/.dslstats/Snapshots as per your revision description statement of 03:00 hrs. today.

In the previous program revision, v.6.3.4 and all previous revisions, I had edited the snapshots directory path to /home/pi/.dslstats/snapshots for better segregation of the snapshot files, just my preference.
I have checked the current dslstats.ini file and under [snapshots] the narrative is "Snapshotdir=/home/pi/.dslstats/" as would be expected with the current, default file path you have set.
I have verified that snapshots do currently save to /home/pi/.dslstats, again, as would be expected.

I'am very happy with your new default snapshot save location, was always my preference anyway, however, how do I get there now as I can no longer edit the file save path ?

Is there a possibility you could have just ommited to add the "/Snapshots" suffix to your default save path ?   
Logged
BT FTTP 150/30, BT Smart Hub 2

kitz

  • Administrator
  • Senior Kitizen
  • *
  • Posts: 33879
  • Trinity: Most guys do.
    • http://www.kitz.co.uk
Re: DSLstats pre-release version 6.3.5
« Reply #9 on: March 31, 2018, 09:07:38 PM »

Thanks eric.   I downloaded it shortly after you posted and its been running ok here for the past 6hrs whilst I've been playing with getting something working so that it will run from a remote website.

I too noticed that the first 2 lines were differently spaced in the datastorage stats file that Stuart mentioned.

Quote
Presumably the kitz webserver files would now have to be copied to the "Webserver" folder ?

I just left that alone and only copied over the .exe and changelog file to my existing directory.   
I always do it that way and only ever replace any files with a new date as I find it quicker to update that way. 
Logged
Please do not PM me with queries for broadband help as I may not be able to respond.
-----
How to get your router line stats :: ADSL Exchange Checker

burakkucat

  • Respected
  • Senior Kitizen
  • *
  • Posts: 38300
  • Over the Rainbow Bridge
    • The ELRepo Project
Re: DSLstats pre-release version 6.3.5
« Reply #10 on: March 31, 2018, 09:19:13 PM »

I, too, see that the first two lines of the "DataStore/date/Stats" file are not separated by a new-line character and all subsequent lines beginning with a space character. Here follows the first three lines from my "Stats" file --

Quote
31/03/2018 19:18 5120 763 7.0 12.9 0.0 12.7 6008 992 ATM 0.00 0.00 0 0 0 0 21150 0 0 0 0 5.875 0 0 0 0 0 0 0 0 0 0 0 0 5451 0 0 32 8 47 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 Showtime 8000 -1 L0 N/A ON ON No Showtime 44.5 27.1 160 95 1 1 1 1 16 8 1.0000 3.9809 1416 209 0 0 0 0 0 0 0 0 0 0 0 54 54 1.00 1.00 0 0 8 8 0 0 629 26 ADSL2 0 0 0 0 44.5 27.1 44.7 27.7 6008 992 0 0 0 0 0 0   31/03/2018 19:19 5120 763 6.7 12.8 0.0 12.7 5916 992 ATM 0.00 0.00 0 0 0 0 21209 0 0 32 0 5.891 0 0 32 0 0 0 0 0 0 0 0 0 5451 0 0 32 8 47 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 Showtime 8000 -1 L0 N/A ON ON No Showtime 44.5 27.1 160 95 1 1 1 1 16 8 1.0000 3.9809 1416 209 0 0 0 0 0 0 0 0 0 0 0 54 54 1.00 1.00 0 0 8 8 0 0 651 26 ADSL2 22 0 0 0 44.5 27.1 44.7 27.7 5916 992 0 0 0 0 0 0
  31/03/2018 19:20 5120 763 7.3 12.9 0.0 12.7 6048 992 ATM 0.00 0.00 0 0 0 0 21269 0 0 47 0 5.908 0 0 47 0 0 0 0 0 0 0 0 0 5451 0 0 32 8 47 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 Showtime 8000 -1 L0 N/A ON ON No Showtime 44.5 27.1 160 95 1 1 1 1 16 8 1.0000 3.9809 1416 209 0 0 0 0 0 0 0 0 0 0 0 54 54 1.00 1.00 0 0 8 8 0 0 672 28 ADSL2 21 2 0 0 44.5 27.1 44.7 27.7 6048 992 0 0 0 0 0

As the "Stats" file is pure ASCII text, perhaps it could have a ".txt" extension?
Logged
:cat:  100% Linux and, previously, Unix. Co-founder of the ELRepo Project.

Please consider making a donation to support the running of this site.

Westie

  • Kitizen
  • ****
  • Posts: 1596
Re: DSLstats pre-release version 6.3.5
« Reply #11 on: March 31, 2018, 10:21:25 PM »

Thanks, Eric. The work you are putting in is much appreciated.

Downloaded (clean install) and running on RPi Zero W, as expected.
Snapshots and Datastore set to save daily at 23:59, so have not observed new-line or extra space anomaly reported by others.
Snapshots, Datastore and Webserver files saved to appropriate folders on local NAS. Browsing to the correct directory when setting the Configuration was easy, and performed flawlessly.

Thank you again.
Logged

broadstairs

  • Kitizen
  • ****
  • Posts: 3697
Re: DSLstats pre-release version 6.3.5
« Reply #12 on: March 31, 2018, 10:40:30 PM »

Eric the format of my stats file is the same as that posted by burakkucat, I'll email my file anyway.

Stuart
Logged
ISP:Vodafone Router:Vodafone Wi-Fi hub FTTP

roseway

  • Administrator
  • Senior Kitizen
  • *
  • Posts: 43432
  • Penguins CAN fly
    • DSLstats
Re: DSLstats pre-release version 6.3.5
« Reply #13 on: March 31, 2018, 10:55:52 PM »


I most likely have not expressed myself very well, what I am trying to say:
In Configuration / Snapshots / Snapshots Directory: the default path stated is now /home/pi/.dslstats/ I would have expected this to be /home/pi/.dslstats/Snapshots as per your revision description statement of 03:00 hrs. today.

Did you delete (or rename) the present dslstats.ini file before running v6.3.5? As I said before, 'default' means running the program as a new user, without any existing configuration. I just tried this on my system, and it responded as described, allocating "/home/eric/.dslstats/Snapshots" as the snapshots directory. This was on a Linux system, not the Raspberry Pi, but the code is the same so the result on the RPi should be the same.

Quote
In the previous program revision, v.6.3.4 and all previous revisions, I had edited the snapshots directory path to /home/pi/.dslstats/snapshots for better segregation of the snapshot files, just my preference.
I have checked the current dslstats.ini file and under [snapshots] the narrative is "Snapshotdir=/home/pi/.dslstats/" as would be expected with the current, default file path you have set.

No, as I said, that isn't how it's set.

Quote
I have verified that snapshots do currently save to /home/pi/.dslstats, again, as would be expected.

I'am very happy with your new default snapshot save location, was always my preference anyway, however, how do I get there now as I can no longer edit the file save path ?

You can no longer manually edit the directory, but you can still click on the directory icon at the end of the box and select your preferred directory there.
« Last Edit: March 31, 2018, 11:16:55 PM by roseway »
Logged
  Eric

roseway

  • Administrator
  • Senior Kitizen
  • *
  • Posts: 43432
  • Penguins CAN fly
    • DSLstats
Re: DSLstats pre-release version 6.3.5
« Reply #14 on: March 31, 2018, 11:09:51 PM »

The FTP upload is working OK for Stats but windows complains it does not know what to open the file with as it has no extension, would be good to add one, also the data in the file is OK but alignment is off - there are two lines of data on the first line and all subsequent lines after first have an additional space in column 1 which might be problematic in parsing in future by program.

I, too, see that the first two lines of the "DataStore/date/Stats" file are not separated by a new-line character and all subsequent lines beginning with a space character.

I too noticed that the first 2 lines were differently spaced in the datastorage stats file that Stuart mentioned.

The issue here is not the file, but the way you're reading it. There are no newline characters in the file, it's just a long string with the fields delineated with spaces. If you open it in a GUI text editor this will break lines according to its own rules. Stuart and Kitz - if you open it in Wordpad you won't see any leading spaces. Or any of you could open it in Libre Office Writer, and again there won't be any leading spaces. Change the font size and you'll see that the line breaks are in different places.
« Last Edit: March 31, 2018, 11:12:39 PM by roseway »
Logged
  Eric
Pages: [1] 2 3