Kitz Forum

Broadband Related => Router Monitoring Software => Topic started by: roseway on March 27, 2018, 04:09:30 PM

Title: DSLstats pre-release version 6.3.4
Post by: roseway on March 27, 2018, 04:09:30 PM
Changes since v6.3.1:
This is work in progress, and I would appreciate comments on the new features.

The third item is a stage on the way to uploading the data store files to a remote location of the user's choice. If you have FTP access to a server you can enter the details and click the Test button. DSLstats will attempt to upload two small files to the server, and will report success or failure.

Regarding the last item, when you first run this version it will convert any already existing configuration to the new style, so the data store and webserver should continue to work in the same way. After that, if you change the data store or webserver locations you will need to specify the full path (previously DSLstats appended 'DataStore' or 'webserver' to the path selected by the user).

http://dslstats.me.uk/downloads.html

Title: Re: DSLstats pre-release version 6.3.4
Post by: broadstairs on March 27, 2018, 04:44:02 PM
Eric I downloaded and installed it OK, however it did mess up the location for my webserver files. I had it set to D:\xampp\htdocs\DSLStatsWeb\webserver but it cam up as D:\xampp\htdocs\DSLStatsWebwebserver (no \). Anyway corrected the file locations OK in the settings and now is using the locations I wanted. Shut it down in order to clean up directories and on restart it shows duplicate messages now. See attached png file. Otherwise all OK so far. Will test FTP later.

Stuart
Title: Re: DSLstats pre-release version 6.3.4
Post by: burakkucat on March 27, 2018, 06:07:06 PM
Downloaded and now currently executing. I am happy to confirm that the first bullet point of the changes is as expected.

I note that there is a missing '/' (equivalent to the missing '\' that Stuart has reported) for the webserver files.

For consistency, could the sub-directories by default be "DataStore", "Snapshots" and "Webserver"?

(Cosmetic.) Under the "Configuration ---> Snapshots" tab, could the first line read "Snapshots directory:" rather than the current "Snapshot directory:? (Plural rather then singular, for consistency under the configuration tab.)
Title: Re: DSLstats pre-release version 6.3.4
Post by: jelv on March 27, 2018, 06:36:50 PM
I also had the issue of it deciding to use W:\DSLstatswebserver instead of W:\DSLstats\webserver
Title: Re: DSLstats pre-release version 6.3.4
Post by: Westie on March 27, 2018, 07:28:18 PM
Downloaded to RPi Zero W and working well, using the default data store: /home/pi/.dslstats/Datastore

Bullet points 1 & 2 working as expected.

The Data Upload test to a NAS on the home LAN reports as successful, but I cannot see any files written there.
I have not attempted the webserver, because the CPU on this device is not really suited for it.
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 27, 2018, 07:37:08 PM
Thank you for the comments.

@Westie: The uploaded files are crc.html and ftc.html, chosen simply because they're small and present in every DSLstats installation. If they're really not there then the test isn't working quite right.


Title: Re: DSLstats pre-release version 6.3.4
Post by: Westie on March 27, 2018, 08:51:40 PM
I have just tried the upload test again, but this time to a non-existent directory on the NAS, to see what errors might be reported. The Event Log reports:
Code: [Select]
27 Mar 2018 20:43:48  File ""crc.html" failed to upload. FTP upload aborted
Are the different number of double quotes before and after the file name significant?
Title: Re: DSLstats pre-release version 6.3.4
Post by: tiffy on March 27, 2018, 08:53:13 PM
V.6.3.4 running on my old RPi 1B and the 2 remote RPi Zero W's I look after, can only comment on bullet points 1 & 2 which are working fully to expectation.

One very minor issue I have noted is in Graphs/Sampling/Time per page, I am currently running @ 1 day, zero hours settings which is working exactly as it should, however, on RPi re-booting the hours setting always increments to "1" reflected on the graphs time axis as would be expected.
Have tried increasing the days setting beyond 1 (again with zero hours) but the hours will always increment to "1" on RPi reboot.

This was the same on the previous program revision, apologies, never remembered to submit report.

I know you have discussed the graphs Days/Hours settings in the previous V.6.3.1 thread but have not seen this particular anomaly reported to date.

Again, many thanks for your continuing development work on DSLStats, very much appreciated.
Title: Re: DSLstats pre-release version 6.3.4
Post by: broadstairs on March 27, 2018, 09:33:22 PM
Just tested the ftp. Initially it said it worked but nothing uploaded.

Stuart
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 27, 2018, 10:51:22 PM
I've worked out why the FTP uploads appear to fail: during testing I set it up to delete the files after uploading, and left the deletion code in the version I released. So if you got a "Success" result it really did work.
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 27, 2018, 10:56:03 PM
@Westie: the extra pair of inverted commas is just a mistake in constructing the error message. I'll fix it.
Title: Re: DSLstats pre-release version 6.3.4
Post by: broadstairs on March 27, 2018, 10:56:50 PM
I've worked out why the FTP uploads appear to fail: during testing I set it up to delete the files after uploading, and left the deletion code in the version I released. So if you got a "Success" result it really did work.

Well that explains it  ;)

Stuart
Title: Re: DSLstats pre-release version 6.3.4
Post by: Westie on March 27, 2018, 11:15:34 PM
I'll fix it.
Thanks, Eric. I really appreciate what you are doing.
Title: Re: DSLstats pre-release version 6.3.4
Post by: burakkucat on March 28, 2018, 01:58:47 AM
Something I have noticed about the names of the files in the sub-directories of the DataStore directory . . .

[Duo2 DataStore]$ ls -1 2018-03-28
Bits-00-33-28.zip
Hlog-00-33-28.zip
QLN-00-33-28.zip
SNR-00-33-28.zip
Stats
[Duo2 DataStore]$


The files are currently named as "name-hour-minute-day_of_month.zip"

Could the naming be adjusted so that the slowest changing parameter is at the left and the fastest changing parameter is at the right, please? I.e. "name-day_of_month-hour-minute.zip"
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 28, 2018, 07:35:54 AM
You're right, it's not very logical. In fact, these files really don't need a 'day' reference at all because they're in daily folders anyway. So "name-hour-minute.zip" would suffice and would slightly reduce the cluttered appearance.
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 28, 2018, 11:51:01 AM
Status report

Concerning the missing / or \ in the updated location of the webserver files: this didn't occur if the location had previously been left at its default, which explains why not everyone saw the error. I've fixed it now.

Duplicate event log messages reporting the location of the webserver files: this should now be fixed.

Extra " in error message about a failed FTP test upload: now fixed.

Setting the graph time per page, zero hours becomes one hour after restarting DSLstats: now fixed.

Test files missing after FTP test upload: I've removed the code which deleted these after uploading, because it resulted in confusion. Also I'm going to rename these files 'FTPtest1' and 'FTPtest2' so that their purpose is clear.
Title: Re: DSLstats pre-release version 6.3.4
Post by: burakkucat on March 28, 2018, 02:52:14 PM
So "name-hour-minute.zip" would suffice and would slightly reduce the cluttered appearance.

Thank you.
Title: Re: DSLstats pre-release version 6.3.4
Post by: ktz392837 on March 28, 2018, 07:25:29 PM
A bit late but RPI version, bug report and a couple of requests.

Directory locations were correct after upgrade (no missing /'s]

Between samplings renamed directory to datastore (from DataStore), updated directory setting in dslstats and toggled datastore off/on.

I then noticed 3 directories ataStore, dataStore and datatore containing no files in .dslstats.  Think it was me typing in the new directory (backspaced on D, pressed d, backspaced on S - matches directories created) but I guess it could have been something else.

The graphs on the combined.htm page are all different sizes.  For consistency could these be made the same?  And pushing my luck perhaps size configurable :)

It would also be useful if the red Sampling text that appears top right window could say something like Sampling , Updating Data Store and Updating Webserver.

Many thanks.
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 28, 2018, 10:50:22 PM
The multiple directories are the result of manually editing the directory. Every time you make a change, it creates a directory with the name it currently has, giving the result you saw. I'll see what I can do, but the solution may be to disallow manual editing in this type of control.
Title: Re: DSLstats pre-release version 6.3.4
Post by: ktz392837 on March 28, 2018, 11:40:55 PM
Disallowing manual editing in them fields sounds like the simplest option and would always "work".

The only other option I can think of is only updating when you leave the field instead of each press - not ideal but better.  I prefer stop editing and force editing of INI file though.
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 29, 2018, 07:15:58 AM
Thanks for that. I was coming to the same conclusion.
Title: Re: DSLstats pre-release version 6.3.4
Post by: broadstairs on March 29, 2018, 08:01:34 AM
One thought on this Eric, does it happen if you stop recording? If true it might be worth disallowing changing any settings while recording, or at least disallow changing directories.

Stuart
Title: Re: DSLstats pre-release version 6.3.4
Post by: jelv on March 29, 2018, 09:18:23 AM
Either disallow changes while recording or add an Apply button.
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 29, 2018, 10:03:34 AM
It makes no difference whether it's recording or not: manual editing has the result reported above. In the case of the webserver, changing the location of the files stops the webserver running until it's finished processing the change, so this will happen several times if manual editing is allowed.

As it happens, manual editing was always disallowed in the case of the snapshots directory, and nobody has ever objected to that. My intention is to disallow manual editing for the webserver and data store locations, unless there are strong reasons to do it differently.
Title: Re: DSLstats pre-release version 6.3.4
Post by: jelv on March 29, 2018, 10:14:51 AM
I can't see an issue with that proposal. It allows you to select UNC paths as well as drives.
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 29, 2018, 11:03:25 AM
Thank you :)
Title: Re: DSLstats pre-release version 6.3.4
Post by: g3uiss on March 30, 2018, 12:33:06 AM
Thanks for the latest update. Excellent on server 2008r2 and Server 2012.

No issues all as per change log ok

Tony
Title: Re: DSLstats pre-release version 6.3.4
Post by: tiffy on March 30, 2018, 10:39:40 AM
Status report

Concerning the missing / or \ in the updated location of the webserver files: this didn't occur if the location had previously been left at its default, which explains why not everyone saw the error. I've fixed it now.

Duplicate event log messages reporting the location of the webserver files: this should now be fixed.

Extra " in error message about a failed FTP test upload: now fixed.

Setting the graph time per page, zero hours becomes one hour after restarting DSLstats: now fixed.

Test files missing after FTP test upload: I've removed the code which deleted these after uploading, because it resulted in confusion. Also I'm going to rename these files 'FTPtest1' and 'FTPtest2' so that their purpose is clear.

Eric:
A bit confused, does the "now fixed" mean that you have already modified program rev. 6.3.4 and re-posted or a later revision with fixes applied is still pending as per your normal procedure ?
Title: Re: DSLstats pre-release version 6.3.4
Post by: broadstairs on March 30, 2018, 11:29:46 AM
I just checked the download and the date on the dslstats.exe was the 27th March so I expect this does not contain the fixes.

Stuart
Title: Re: DSLstats pre-release version 6.3.4
Post by: roseway on March 30, 2018, 12:37:06 PM
Sorry for the confusion. I never upload a modified version under the same version number.

I've fixed everything raised in this thread in a new version not yet released. I've also completed the code to enable FTP uploads of the data store. I'm testing this at the moment, then I'll build and test the different operating system versions. This is intended to be the next full release.
Title: Re: DSLstats pre-release version 6.3.4
Post by: tiffy on March 30, 2018, 01:18:09 PM
Thanks for the clarification Eric.
I thought it was unlikely that you would deviate from your normal procedure of incorporating fixes / updates in a later program revision, the confusion (on my part) was that later posts appeared to infer that the "fixes" had already been applied.

I await the next program revision when this can be fitted into your very busy schedule and very much appreciate your dedication to the continuing improvements you are currently producing to DSLStats and the volume of extra work you have undertaken since the sad demise of MDWS.
Title: Re: DSLstats pre-release version 6.3.4
Post by: broadstairs on March 30, 2018, 04:39:49 PM
Eric I must admit that I believed you always did exactly that - upload a new one with a change in number and announce it. However before I jumped in I just checked the date in the zip file just in case.

Stuart