Hi
Of course thermal cycling stresses components, but my point is all electronic products are designed so they aren't stressed enough to fail from it, as otherwise it costs the manufacturer money and lost sales. The X-Box, like any PC really, experiences thermal cycling, regardless if left on 24/7 or not, so the fact it failed wasn't because of thermal cycling (that's a given, you can't remove that from the equation), it failed because of a design flaw, and that flaw can't be extrapolated to other electronic products, well it can, and if it is there is born an urban myth.
Generally devices best fair based on their target usage, so a modem/router expected to be left on 24/7 is tested for that scenario, but the irony here is because they can't wait 1-2 years to see if it would last past the warranty period running 24/7, means they are tested in ovens and exposed to big swings in thermal cycling to accelerate the aging.
So turning off a router/modem each night, it's a poor and weak argument to say don't do it because it will fail sooner, and conversely, the electrolytic capacitors which usually fail in domestic routers/modems will last longer by virtue of being exposed to less heat, so you could argue the opposite.
VDSL modems should be left on 24/7 to avoid problems with time-varying cross talk, and to allow the DLM to manage user connections based on a stable cross talk environment.
Regards
Phil